ci: switch our jobs to mac arm64 #3426
Conversation
Summary of ChangesHello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes our continuous integration setup by migrating all macOS-based CI jobs to utilize Apple Silicon (ARM64) architecture. This change aligns our testing environment with the more prevalent hardware in our user base and clarifies the official support tiers for different macOS platforms in our documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly switches the macOS CI jobs from Intel-based machines to ARM64, which is a great update to align with the current developer ecosystem. The changes in .bazelci/presubmit.yml to use macos_arm64 and the corresponding update in docs/support.md to move osx_arm64 to a Tier 0 supported platform are consistent with the goal. I've left one comment regarding an inconsistency in CI task naming for future improvement.
| name: "Default: Debian" | ||
| platform: debian11 | ||
| macos: | ||
| macos_arm64: |
There was a problem hiding this comment.
This task key was updated to macos_arm64, which is great for clarity. However, other macOS task keys in this file were not renamed (e.g., integration_test_bzlmod_macos), creating an inconsistency. For better maintainability, consider renaming all macOS task keys to reflect the architecture change in a follow-up PR.
1 participant
The arm64 macs have been in the wild for a while and it makes more sense
to test against that platform instead of the Intel macs that very few
people in our user-base are using.
At the same time clarify the supported platforms.